[PATCH] D92590: [CodeView] Fix inline sites that are missing code offsets.

[Amy Huang via Phabricator via llvm-commits]

akhuang added inline comments.


================
Comment at: llvm/test/DebugInfo/COFF/inline-site-syms.ll:8-13
+; int test(int x) {
+;   auto f = [](int x) {
+;     return x * 100;
+;   };
+;   return f(x);
+; }
----------------
dblaikie wrote:
> I'd probably suggest a simpler (it's probably about the same in IR, but simpler in terms of language features, names, etc) test case for inlining, something like:
> ```
> void f1();
> __attribute__((always_inline)) void f2() {
>   f1();
> }
> void f3() {
>   f2();
> }
> ```
> 
> If that's adequate.
yep, I mostly used this particular code because the offset of the inline site in the function happens to be 0. But I suppose this should actually have been an assembly test and  changing the existing tests should be adequate test coverage for this--


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92590/new/

https://reviews.llvm.org/D92590