[PATCH] D92632: [dfsan] Add a test case of storing zero

[Matt Morehouse via Phabricator via llvm-commits]

morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/Instrumentation/DataFlowSanitizer/store.ll:163
+define void @store_zero(i32* %p) {
+  ;  NO_COMBINE_PTR_LABEL: store i64 0, i64* {{.*}}, align 2
+  store i32 0, i32* %p
----------------
stephan.yichao.zhao wrote:
> morehouse wrote:
> > Why is it storing i64 shadow?
> It is testing this branch: 
>    https://github.com/llvm/llvm-project/blob/master/llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp#L1465
> 
> The shadow of (i32 0) is (i64 0).
Right, of course.  I was thinking of TLS, where the shadow would be i16.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92632/new/

https://reviews.llvm.org/D92632