[PATCH] D85278: [lld] Support building shared libLLD.so

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lld/tools/lld-shlib/CMakeLists.txt:16
+  endif()
+  if (BUILD_SHARED_LIBS)
+    # If we are building static libraries, then we don't need to add the static
----------------
Hmm. I think LLVM_BUILD_LLVM_DYLIB & CLANG_BUILD_CLANG_DYLIB are incompatible with BUILD_SHARED_LIBS


================
Comment at: lld/tools/lld-shlib/CMakeLists.txt:24
+  # lld libraries are redundant since we are linking all the individual
+  # object files into libclang-cpp.so, so filter them out from _DEPS.
+  # This avoids problems with LLVM global data when building with
----------------
libclang-cpp.so?


================
Comment at: lld/tools/lld-shlib/CMakeLists.txt:27
+  # BUILD_SHARED_LIBS=ON
+  # FIXME: We could use list(FILTER) with cmake >= 3.6
+  # FIXME: With cmake >= 3.15 we could use the generator expression
----------------
Minimum CMake version has been bumped


================
Comment at: lld/tools/lld-shlib/lld-shlib.cpp:1
+// Intentionally empty source file to make CMake happy
----------------
Can you just merge lld-shlib/* to the main CMakeLists.txt to avoid a directory?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85278/new/

https://reviews.llvm.org/D85278