[PATCH] D92420: [PowerPC] Exploitation of xxeval instruction for AND and NAND
Victor Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 4 09:16:39 PST 2020
NeHuang accepted this revision.
NeHuang added a comment.
LGTM other than one minor can be addressed when committing.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:2565
+multiclass xxevalPattern <dag pattern, bits<8> imm> {
+ def : Pat<(v4i32 pattern), (XXEVAL $vA, $vB, $vC, imm)>;
----------------
bsaleil wrote:
> I think we don't need a multiclass here:
> ```class xxevalPattern <dag pattern, bits<8> imm> :
> Pat<(v4i32 pattern), (XXEVAL $vA, $vB, $vC, imm)> {}```
Agree with Baptiste's point above that we can use class here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92420/new/
https://reviews.llvm.org/D92420
More information about the llvm-commits
mailing list