[PATCH] D92588: [Doc][NFC] Fix Kaleidoscope links, typos, cfg image and add blog posts for MCJIT
Florian Hahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 4 09:11:29 PST 2020
fhahn added a reviewer: lhames.
fhahn added a subscriber: lhames.
fhahn added a comment.
@lhames could you take a quick look at the orcjit related changes?
================
Comment at: llvm/docs/tutorial/LangImpl01.rst:7
-The Kaleidoscope Tutorial has `moved to another location <MyFirstLanguageFrontend/index.html>`_ .
+The Kaleidoscope Tutorial has `moved to another location <MyFirstLanguageFrontend/index.rst>`_ .
----------------
This won't work I think, because this will treat it as external link.
I think you can use the `:doc:` directive to reference internal pages, like
```
:doc:`MyFirstLanguageFrontend/index
```
================
Comment at: llvm/docs/tutorial/MyFirstLanguageFrontend/LangImpl05.rst:359
important) aspect of the LLVM IR is that it `requires all basic blocks
-to be "terminated" <../LangRef.html#functionstructure>`_ with a `control
-flow instruction <../LangRef.html#terminators>`_ such as return or
+to be "terminated" <../../LangRef.html#functionstructure>`_ with a `control
+flow instruction <../../LangRef.html#terminators>`_ such as return or
----------------
While you are here, we could just update those links to use internal references. Something like the code below should do it.
```
:ref:`requires all basic blocks to be "terminated" <functionstructure>`
```
and
```
:ref:`control flow instruction <terminators>`
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92588/new/
https://reviews.llvm.org/D92588
More information about the llvm-commits
mailing list