[PATCH] D92612: [MC] Consume EndOfStatement in .cfi_{sections,endproc}

[Scott Linder via Phabricator via llvm-commits]

scott.linder added inline comments.


================
Comment at: llvm/test/MC/AsmParser/directive-parse-err.s:1
+// RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 | FileCheck %s
+// RUN: not llvm-mc -triple i386-unknown-unknown %s 2>&1 | grep "error:" | count 6
----------------
MaskRay wrote:
> Please merge this into a `.cfi_*` parsing test. You can leverage `-defsym ERR=1` to check errors. See `MC/ELF/reloc-directive.s` for an example
To clarify, is there an "omnibus" cfi parsing test under `MC/AsmParser`? I see a few specific examples, but not just `cfi.s`. Did you have a particular test in mind?


================
Comment at: llvm/test/MC/AsmParser/directive-parse-err.s:6
+
+// CHECK: [[@LINE+1]]:15: error: Expected an identifier
+.cfi_sections $
----------------
MaskRay wrote:
> `[[@LINE+1]]` is deprecated. Use `[[#@LINE+1]]`
Sorry, I keep forgetting this when I look at existing tests as templates. I'll update this in the next patch!


================
Comment at: llvm/test/MC/AsmParser/round-trip.s:16
+.cfi_endproc
+.cfi_startproc
+.cfi_endproc
----------------
MaskRay wrote:
> One pair .cfi_startproc of should be sufficient.
Agreed, I'm not sure why I added the repeated pairs, I'll update this in the next patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92612/new/

https://reviews.llvm.org/D92612