[PATCH] D92624: [mac/lld] Add support for the LC_LINKER_OPTION load command in o files

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/MachO/Driver.cpp:370-371
+    fatal(Twine(args.getArgString(missingIndex)) + ": missing argument");
+  for (auto *arg : args.filtered(OPT_UNKNOWN))
+    error("ignoring unknown argument: " + arg->getAsString(args));
+
----------------
int3 wrote:
> is this necessary given that we are going to error out anyway at line 382 below?
I guess it's not strictly necessary. It matches the flow in parseDirectives() in lld/COFF. The reasoning is probably that this first stage gives you a list of generally valid args, and the 2nd pass below checks which of them are valid in directives / load commands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92624/new/

https://reviews.llvm.org/D92624