[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 4 01:21:17 PST 2020


serge-sans-paille added a comment.

In D92245#2425817 <https://reviews.llvm.org/D92245#2425817>, @emaste wrote:

>> How do things go wrong on Darwin? I was under the impression that this was implemented in LLVM as strictly inline code, no runtime support required.
>
> That is my impression as well (although it seems that an earlier version might have emitted calls to a stack probe routine?)

The original security advisory doesn't mention Darwin, but there's nothing specific to Darwin in the stack clash protection implementation, so I'm fine with allowing it for Darwin too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92245/new/

https://reviews.llvm.org/D92245



More information about the llvm-commits mailing list