[PATCH] D92089: [PowerPC] Materialize i64 constants by enumerated patterns.

Fri Dec 4 00:24:35 PST 2020

Esme added a comment.

In D92089#2427656 <https://reviews.llvm.org/D92089#2427656>, @steven.zhang wrote:

> I think, this patch overrall looks great as it simplify our logic of the instruction selection for i64 imm. Please update the check with isS[U]Int<>() to make the code more clear. And I assume that, you have run the bmk and bootstrap with this patch.

Thanks for your review. Yes I agree it would be much more readable to define patterns with isS[U]Int<>(). But it's hard to present all patterns by this way. Sorry that I didn't update the check. More documentations were added, and I hope it made the code more clear.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92089/new/

https://reviews.llvm.org/D92089