[PATCH] D92073: [CodeGen] Add text section prefix for COFF object file

[TaoPan via Phabricator via llvm-commits]

TaoPan added inline comments.


================
Comment at: llvm/test/Transforms/CodeGenPrepare/X86/section.ll:47
 ; CHECK: cold_func1{{.*}}!section_prefix ![[COLD_ID:[0-9]+]]
 ; ASM1: .section .text.unlikely.,"ax", at progbits
 ; ASM2: .section .text.unlikely.cold_func1,"ax", at progbits
----------------
rnk wrote:
> The section name is `.text.unlikely.`, with a trailing dot. I guess that is the existing behavior, but it seems odd to me. Nevermind.
Yes, the existing code
https://github.com/llvm/llvm-project/blob/master/llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp#L633

  } else if (HasPrefix)
    Name.push_back('.');
leads to the trailing dot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92073/new/

https://reviews.llvm.org/D92073