[PATCH] D92631: correcting X86OutgoingValueHandler typo (NFC)

Chris Sears via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 21:25:38 PST 2020


CSears created this revision.
CSears added reviewers: arsenm, craig.topper.
Herald added subscribers: pengfei, hiraditya.
CSears requested review of this revision.
Herald added a subscriber: wdng.
Herald added a project: LLVM.

The X86OutgoingValueHandler declaration has a typo. It subclasses IncomingValueHandler rather than OutgoingValueHandler. This isn't actually a 'bug' because both IncomingValueHandler and OutgoingValueHandler have the same 'shape'. It's just a typo. This typo is only in the X86 backend.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92631

Files:
  llvm/lib/Target/X86/X86CallLowering.cpp


Index: llvm/lib/Target/X86/X86CallLowering.cpp
===================================================================
--- llvm/lib/Target/X86/X86CallLowering.cpp
+++ llvm/lib/Target/X86/X86CallLowering.cpp
@@ -95,11 +95,11 @@
 
 namespace {
 
-struct X86OutgoingValueHandler : public CallLowering::IncomingValueHandler {
+struct X86OutgoingValueHandler : public CallLowering::OutgoingValueHandler {
   X86OutgoingValueHandler(MachineIRBuilder &MIRBuilder,
                           MachineRegisterInfo &MRI, MachineInstrBuilder &MIB,
                           CCAssignFn *AssignFn)
-      : IncomingValueHandler(MIRBuilder, MRI, AssignFn), MIB(MIB),
+      : OutgoingValueHandler(MIRBuilder, MRI, AssignFn), MIB(MIB),
         DL(MIRBuilder.getMF().getDataLayout()),
         STI(MIRBuilder.getMF().getSubtarget<X86Subtarget>()) {}
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92631.309452.patch
Type: text/x-patch
Size: 833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201204/d9243b23/attachment.bin>


More information about the llvm-commits mailing list