[PATCH] D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 20:11:18 PST 2020


tlively accepted this revision.
tlively added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:940
 
-      bool is64 = config->is64.getValueOr(false);
+      auto writeGetFlag = [&]() {
+        if (config->isPic) {
----------------
I think this will make the logic clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92620/new/

https://reviews.llvm.org/D92620



More information about the llvm-commits mailing list