[PATCH] D92621: [SampleFDO] Store fixed length MD5 in NameTable instead of using ULEB128 if MD5 is used.

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 19:38:25 PST 2020


davidxl added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:794
 std::error_code SampleProfileReaderExtBinaryBase::readNameTableSec(bool IsMD5) {
-  if (IsMD5)
+  if (IsMD5 || FixLengthMD5)
     return readMD5NameTable();
----------------
Does FixLengthMD5 imply IsMD5, so IsMD5 is enough?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92621/new/

https://reviews.llvm.org/D92621



More information about the llvm-commits mailing list