[PATCH] D92616: [NewPM] Make pass adaptors less templatey

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

Once you've rebased on the other changes this LGTM.



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:476
 void PrintIRInstrumentation::printBeforePass(StringRef PassID, Any IR) {
-  if (PassID.startswith("PassManager<") || PassID.contains("PassAdaptor<"))
+  if (isIgnored(PassID))
     return;
----------------
aeubanks wrote:
> dexonsmith wrote:
> > Could / should these changes to use `isIgnored` be committed separately / ahead of time?
> it is related to this change but can be done ahead of time: https://reviews.llvm.org/D92625
Thanks!


================
Comment at: llvm/lib/Transforms/Scalar/LoopPassManager.cpp:89
 }
+} // namespace llvm
+
----------------
aeubanks wrote:
> dexonsmith wrote:
> > Can adding this comment be pulled out to a separate commit? It seems unrelated to this change.
> this seems fairly benign to me, but sure
Thanks, I don't think it needs review or anything, but I had to stare at the diff for a while to see what had happened to the braces... if you commit unrelated comment / whitespace changes separately then later when people look at the log / blame / etc. it'll be a bit cleaner (in this chunk, the "new" brace will be the closing one for `FunctionToLoopPassAdaptor::run` instead of this one here)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92616/new/

https://reviews.llvm.org/D92616