[PATCH] D92480: [llvm] Unify interface of (ThreadSafe)?RefCountedBase

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 17:45:23 PST 2020


dblaikie added a comment.

I've committed 2e83ccc2ee333389110659f3cb313968a0c970d4 <https://reviews.llvm.org/rG2e83ccc2ee333389110659f3cb313968a0c970d4> which takes parts of this patch - specifically fixing the test that was already intended to test the RefCountedBase's copy constructor, but didn't (because the test called the default constructor instead) and extending it to test/cover (& also fix) the similar behavior in ThreadSafeRefCountedBase.

That should leave this proposed patch to add the dtors and assertions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92480/new/

https://reviews.llvm.org/D92480



More information about the llvm-commits mailing list