[PATCH] D92616: [NewPM] Make pass adaptors less templatey

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added a comment.

This seems like a great improvement!



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:476
 void PrintIRInstrumentation::printBeforePass(StringRef PassID, Any IR) {
-  if (PassID.startswith("PassManager<") || PassID.contains("PassAdaptor<"))
+  if (isIgnored(PassID))
     return;
----------------
Could / should these changes to use `isIgnored` be committed separately / ahead of time?


================
Comment at: llvm/lib/Transforms/Scalar/LoopPassManager.cpp:89
 }
+} // namespace llvm
+
----------------
Can adding this comment be pulled out to a separate commit? It seems unrelated to this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92616/new/

https://reviews.llvm.org/D92616