[PATCH] D92334: [CSSPGO][llvm-profgen] Pseudo probe decoding and disassembling

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-cs-pseudoprobe.test:113
+
+#include <stdio.h>
+
----------------
A comment on the clang command line to build the program?


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.h:41
+// Use func GUID and index as the location info of the inline site
+struct InlineSite {
+  uint64_t GUID = 0;
----------------
May just use `std::pair' which has predefined hash and equal operators?


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.h:183
+  /// SectionName used for debug
+  std::string SectionName;
+
----------------
Make it a debug field? i.,e under #ifndef NDEBUG.


================
Comment at: llvm/tools/llvm-profgen/PseudoProbe.h:27
+// Pseudo probe type
+enum PseudoProbeType {
+  BLOCK = 0,
----------------
Some parts of this file can be merged with `llvm/include/llvm/IR/PseudoProbe.h`.  Consider moving non-decoding-specific stuff into the common header?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92334/new/

https://reviews.llvm.org/D92334