[PATCH] D92620: [lld][WebAssembly] Add suppport for PIC + passive data initialization
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 3 16:58:57 PST 2020
dschuff added inline comments.
================
Comment at: lld/wasm/Writer.cpp:879
+ writeUleb128(os, 1, "local count");
+ writeU8(os, WASM_TYPE_I32, "address type");
+ writeU8(os, WASM_OPCODE_GLOBAL_GET, "GLOBAL_GET");
----------------
should this be conditionalized for wasm64?
alternatively, throw a nice error if we don't want to implement it right now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92620/new/
https://reviews.llvm.org/D92620
More information about the llvm-commits
mailing list