[PATCH] D92404: [FileCheck] Enforce --allow-unused-prefixes=false for llvm/test/Transforms

Thu Dec 3 14:18:23 PST 2020

mtrofin added a comment.

In D92404#2432190 <https://reviews.llvm.org/D92404#2432190>, @lebedev.ri wrote:

> In D92404#2432042 <https://reviews.llvm.org/D92404#2432042>, @mtrofin wrote:
>
>> In D92404#2431929 <https://reviews.llvm.org/D92404#2431929>, @lebedev.ri wrote:
>>
>>> IMO this whole direction is wrong, but i'll guess i'll just have to suffer with new reality.
>>
>> Not sure what direction you're referring to - if it's about handing unused prefixes,
>
> Yep, precisely that direction.
>
>> could you please contribute to the RFC thread (http://lists.llvm.org/pipermail/llvm-dev/2020-October/146162.html), it would be helpful to understand what tradeoffs we may have missed.
>>
>> Thanks!
>
> I have not kept track of that RFC so i'm not sure if i'm just being picky because i'm not aware of a very good reasons pointed out there.

OK.

Any pushback re. this patch?

Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92404/new/

https://reviews.llvm.org/D92404