[PATCH] D87216: [NewPM] Support --print-before/after in NPM

Thu Dec 3 11:54:43 PST 2020

ychen added a comment.

In D87216#2431626 <https://reviews.llvm.org/D87216#2431626>, @aeubanks wrote:

> In D87216#2431508 <https://reviews.llvm.org/D87216#2431508>, @ychen wrote:
>
>> It is very unfortunate that we have to manage and translate between two sets of names (one pass name and one type name). This makes me wonder if we just keep the pass name as the return value of PassInfoMixin::name and get rid of class name everywhere. Right now I couldn't think of anything is blocking us from doing that. WDYT?  @asbirlea ?
>
> We'd have to move the names from PassRegistry.def to every pass class definition which would be a lot of work but definitely feasible.

That's true. The issue of translation also happens for codegen using NPM where both target-dependent and target-independent passes need the translation. Looking at my prototype, there is a lot of boilerplate for that. I think the one-time cost of moving names around should be worthwhile.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87216/new/

https://reviews.llvm.org/D87216