[PATCH] D91418: [LLD][ELF] Rename lld elf driver main function

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 11:52:06 PST 2020


aganea added a comment.

In D91418#2431461 <https://reviews.llvm.org/D91418#2431461>, @sbc100 wrote:

> In D91418#2431400 <https://reviews.llvm.org/D91418#2431400>, @rksharma wrote:
>
>> In D91418#2431314 <https://reviews.llvm.org/D91418#2431314>, @MaskRay wrote:
>>
>>> I think changing from `main` to `to` avoids an issue and adds a new issue. We should fix the issues all together, and this requires consensus from others ports to proceed.
>>
>> Is the new issue, the clash with `lld::*::link` and if so, then ideally we should replace `link` from all the ports to `linkerMain`?
>
> `lldMain`?

I would give +1 to `linkerMain` since it is unique and we already have `lldMain` in `lld/tools/lld/lld.cpp` (and we would otherwise end up with a similar issue as what this patch tries to correct)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91418/new/

https://reviews.llvm.org/D91418



More information about the llvm-commits mailing list