[PATCH] D92514: Switch from llvm::is_trivially_copyable to std::is_trivially_copyable

Thu Dec 3 10:20:13 PST 2020

dblaikie added a comment.

In D92514#2431523 <https://reviews.llvm.org/D92514#2431523>, @MaskRay wrote:

> In D92514#2431499 <https://reviews.llvm.org/D92514#2431499>, @dblaikie wrote:
>
>> Generally - once code is sent for review, it should not be committed without approval: https://llvm.org/docs/CodeReview.html#code-review-workflow
>
> For this one, it was just to have a check on premerge-checks (MSVC appears to have some edge-case issues).

Given this produces email to llvm-commits, I don't think it's appropriate. If phab can be configured in such a way as to not send such email and specifically tag "reviews" as not being for review - I'm OK with that.

> I think it meets likely-community-consensus requirements (previously jlebar and serge-sans-paille and probably others had similar cleanups this year, too)

Agreed - I don't have an issue with the patch itself (I'd have been happy to approve it today), but with the review being sent and then committed without approval.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92514/new/

https://reviews.llvm.org/D92514