[PATCH] D92575: [mac/lld] Run tests with -fatal_warnings by default

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 10:08:51 PST 2020


thakis added a comment.

The tests that check for warnings (there's currently just one) all use `%no_fatal_warnings_lld`. That's still testable with this patch.

The motivation here is that lld/MachO warns on options that are marked HelpHidden and there were several instances were someone implemented a flag but forgot to remove HelpHidden, and then lld still warned about the flag not being implemented even though it is. This prevents that type of error. Also see discussion on D92455 <https://reviews.llvm.org/D92455> -- I strongly prefer this patch here over that other one.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92575/new/

https://reviews.llvm.org/D92575



More information about the llvm-commits mailing list