[PATCH] D92412: [DebugInfo] Add handling of stringLengthExp operand of DIStringType

[Chih-Ping Chen via Phabricator via llvm-commits]

cchen15 marked 5 inline comments as done.
cchen15 added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp:696
 
   if (DIVariable *Var = STy->getStringLength()) {
     if (auto *VarDIE = getDIE(Var))
----------------
SouraVX wrote:
> cchen15 wrote:
> > Can we consolidate stringLength and stringLengthExp into one operand? It seems to me that a DIStringType can have one or the other, but not both.
> Thanks! makes sense in general. (As a side note, just please make sure we don't accidentally mess/touch up exisiting `assumed length string` support).
Thanks for the feedback. I plan to add data_location operand to DIStringType in the next couple of weeks. I will include in that patch the consolidation of stringLength and stringLengthExp.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92412/new/

https://reviews.llvm.org/D92412