[PATCH] D92538: [RISCV] Merge FMV_H_X_RV32/FMV_H_X_RV64 into a single opcode. Same with FMV_X_ANYEXTH_RV32/RV64

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 09:13:55 PST 2020


frasercrmck added a comment.

Makes sense to me otherwise but I'll defer my LGTM to someone else.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.h:56
   //
-  // FMV_H_X_RV32/RV64 match the semantics of the FMV.H.X.
-  // FMV_X_ANYEXTH_RV32/RV64 are similar to FMV.X.H but has an any-extended
-  // result.
+  // FMV_H_X match the semantics of the FMV.H.X.
+  // FMV_X_ANYEXTH are similar to FMV.X.H but has an any-extended result.
----------------
nit: the comments for these notes are still third-person plural despite each being a single node: `match` and `are`; I think `matches` and `is` is better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92538/new/

https://reviews.llvm.org/D92538



More information about the llvm-commits mailing list