[PATCH] D90020: [AArch64][SVE] Emit DWARF location expression for SVE stack objects.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 09:00:29 PST 2020


david-arm added a comment.

I think the approach here looks good to me, but maybe give others a chance to review first?



================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp:618
+    Ops.push_back(dwarf::DW_OP_plus);
+
+  } else if (VGSized < 0) {
----------------
nit: Additional whitespace


================
Comment at: llvm/test/CodeGen/AArch64/debug-info-sve-dbg-value.mir:15
+#
+# CHECK2: : DW_OP_breg31 WSP+16, DW_OP_lit16, DW_OP_bregx VG+0, DW_OP_mul, DW_OP_plus)
+# CHECK2: DW_AT_type {{.*}}svint32_t
----------------
I'm not very familiar with the DWARF dump so I apologise if I misunderstood something, but is this only testing either pure scalable or pure fixed offsets? Looking at fillOffsetExpression I thought there might be offsets made up of byte-sized and vg-sized offsets, i.e. with two DW_OP_plus commands.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90020/new/

https://reviews.llvm.org/D90020



More information about the llvm-commits mailing list