[PATCH] D92052: [MC][ELF] Accept abbreviated form with sh_flags and sh_entsize

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/MC/ELF/section-entsize-changed.s:14
+
+bar:
+.section .bar
----------------
The labels are unused. Please remove them.


================
Comment at: llvm/test/MC/ELF/section-entsize-changed.s:18
+# CHECK: {{.*}}.s:[[# @LINE+1]]:1: error: changed section flags for .bar, expected: 0x0
+.section .bar,"awx", at progbits
+
----------------
Why does the additional test duplicate the testing of changed flags which has been covered by section-flags-changed.s?


================
Comment at: llvm/test/MC/ELF/section-omitted-attributes.s:13
+
+.section .bar,"aM", at progbits,4
+
----------------
.bar just duplicates .foo , please drop .bar

And also `foo`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92052/new/

https://reviews.llvm.org/D92052