[PATCH] D91589: [DAGCombiner] Fold (sext (not i1 x)) -> (add (zext i1 x), -1)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 08:44:03 PST 2020


spatel added a comment.

In D91589#2431054 <https://reviews.llvm.org/D91589#2431054>, @laytonio wrote:

> Thanks for the review! Could you commit this for me please? Layton Kifer <laytonkifer at gmail.com>

Sure - but I missed something: are we excluding vector types intentionally (do we have any test coverage?) or is that planned as a follow-up? Either way, we should add a code comment to explain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91589/new/

https://reviews.llvm.org/D91589



More information about the llvm-commits mailing list