[PATCH] D92503: [ms] [llvm-ml] Fix case-sensitivity for variables and textmacros

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:1551
+    if (!Sym) {
+      auto VarIt = Variables.find(SymbolName.lower());
+      if (VarIt != Variables.end())
----------------
This looks up a label, and if that fails, tries to look up a var with the same (lowered) name. Is that intentional? If so, could you mention that in the patch summary? As far as I understand, this change is unrelated to what's currently in the description.

Same with the Unlex changes below which I'm guessing are related to this change here.

I understand all the `.lower()` changes in the diff, I think I understand the test, but I don't get why the rest is changing yet.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92503/new/

https://reviews.llvm.org/D92503