[PATCH] D92455: [lld-macho] Error out if we encounter a HelpHidden flag in tests

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

I'm also not a super fan of things depending on env vars:

1. I often copy-paste the output of `llvm-lit lld/tests/some-test.s -vv`. LLD_IN_TEST isn't in that output but set implicitly by lit, so that means copying the env now has magically different behavior (for that reason, a whole bunch of tests in the COFF port explicitly set `env LLD_IN_TESTS=1` redundantly -- but we'd have to add that to every single test)

2. This gives LLD_IN_TEST a much wider semantic meaning than it had before. Before, it's a very targeted thing for making sure we do fast exit and global exception handling and test repeats; now it affects basically anything

I think globally passing `-fatal_warnings` is a bit less surprising, and it's not so bad. I prootyped it in D92575 <https://reviews.llvm.org/D92575> -- wdyt? (I can put in the two test.s changes you have in here if you like it.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92455/new/

https://reviews.llvm.org/D92455