[PATCH] D92094: [CostModel]Replace FixedVectorType by VectorType in costgetIntrinsicInstrCost

Christopher Tetreault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 05:31:07 PST 2020


ctetreau added a comment.

> ... Yes we should do that. From having seen how this work is layered, it will be quite a substantial task ...

Yeah, the TTI changes were one of the most painful parts of the VectorType refactor. From my experience, you're not going to be able to break that up into small patches. There's a billion headers, and they're all tightly coupled. But at some point somebody has to go and update them to return InstructionCost anyways, that seems like a good time to do it.

I am //not// looking forward to resolving that merge conflict in my downstream...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92094/new/

https://reviews.llvm.org/D92094



More information about the llvm-commits mailing list