[PATCH] D92472: [IR] Support scalable vectors in ShuffleVectorInst::increasesLength

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 03:26:04 PST 2020


c-rhodes added inline comments.


================
Comment at: llvm/unittests/IR/InstructionsTest.cpp:1095
+                            UndefValue::get(VScaleV2Int32Ty),
+                            Constant::getNullValue(VScaleV4Int32Ty));
+  EXPECT_TRUE(Id14->changesLength());
----------------
sdesmalen wrote:
> Nothing to change in this patch, but I just thought this interface had been removed so that it would take an ArrayRef instead of a Constant?
> Nothing to change in this patch, but I just thought this interface had been removed so that it would take an ArrayRef instead of a Constant?

There's two interfaces where `Mask` can be either an `llvm::Value` or `ArrayRef<int>`, I think most of these tests are using the former interface since they pass an `llvm::Constant`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92472/new/

https://reviews.llvm.org/D92472



More information about the llvm-commits mailing list