[PATCH] D92521: [tsan] Fix build failure with _FORTIFY_SOURCE

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 3 01:49:43 PST 2020


serge-sans-paille added inline comments.


================
Comment at: compiler-rt/lib/interception/interception.h:140
+#elif defined(_FORTIFY_SOURCE) && (SANITIZER_FREEBSD || SANITIZER_NETBSD || !SANITIZER_FUCHSIA)
+# define WRAP(x) __interceptor_ ## x
+# define WRAPPER_NAME(x) "__interceptor_" #x
----------------
maybe call them ``__fortified_interceptor`` to make their purpose more explicit?


================
Comment at: compiler-rt/lib/interception/interception_linux.h:35
       (::__interception::uptr *) & REAL(func),    \
-      (::__interception::uptr) & (func),          \
+      (::__interception::uptr) & (DECLARED_FUNC(func)),       \
       (::__interception::uptr) & WRAP(func))
----------------
I don't find `DECLARED_FUNC` as explicit as `REAL` and `WRAP`. `ALIAS` ?  `EXTERNAL` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92521/new/

https://reviews.llvm.org/D92521



More information about the llvm-commits mailing list