[PATCH] D92548: [CodeGen] Check if Index's OperandNum == 0 when refineIndexType(...) is called This is a bugfix for D90942
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 3 01:13:20 PST 2020
sdesmalen added a comment.
Thanks for finding and fixing this!
Can the test be simplified by using `<4 x float>` instead of `<48 x float>`?
================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9416
const TargetLowering &TLI = DAG.getTargetLoweringInfo();
+ if(Index.getNumOperands() == 0)
+ return false;
----------------
Probably better to explicitly check if `Index` is not a zero/sign extend, instead of checking whether it has any operands.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92548/new/
https://reviews.llvm.org/D92548
More information about the llvm-commits
mailing list