[PATCH] D92524: [IRSimilarity] Strip out the findSimilarity call from the constructor
Andrew Litteken via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 20:27:30 PST 2020
AndrewLitteken added a comment.
I don't think anything in future patches uses the constructor either so should be ok.
Besides the comment, LGTM, but I would like one of the other reviewers to look at it since I'm still fairly new to LLVM developer community.
================
Comment at: llvm/lib/Analysis/IRSimilarityIdentifier.cpp:664
bool IRSimilarityIdentifierWrapperPass::runOnModule(Module &M) {
// All the real work is done in the constructor for the pass.
+ IRSI->findSimilarity(M);
----------------
We can get rid of/change this comment now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92524/new/
https://reviews.llvm.org/D92524
More information about the llvm-commits
mailing list