[PATCH] D92398: [AIX][XCOFF] emit traceback table for function in aix

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetMachine.h:275-277
+  /// Return true if should emit traceback table for asm in AIX OS or xcoff
+  /// object file
+  /// corresponding to -xcoff-traceback-table.
----------------
jasonliu wrote:
> I don't think it's necessary for us to mention about asm or XCOFF object file. 
s/xcoff/XCOFF/; in comments and messages.


================
Comment at: llvm/include/llvm/Target/TargetOptions.h:250
 
+    /// Emit traceback table for asm in AIX OS or xcoff object file.
+    unsigned XCOFFTracebackTable : 1;
----------------
jasonliu wrote:
> No need to mention about asm or object file. 
Same comment re: "XCOFF".


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1742-1744
+    "C",     "FORTRAN", "Pascal",    "ADA",      "PL/I",
+    "BASIC", "LISP",    "COBOL",     "Modulas2", "C++",
+    "RPG",   "PL8",     "Assembler", "Java",     "Objective C"};
----------------
Match AIX documentation on style used for language names (for documented cases).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92398/new/

https://reviews.llvm.org/D92398