[PATCH] D92522: [SmallVector] Allow SmallVector<T>

Sean Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 17:04:27 PST 2020


silvas marked an inline comment as done.
silvas added a comment.

In D92522#2429795 <https://reviews.llvm.org/D92522#2429795>, @dblaikie wrote:

> I'm generally good with this in terms of incremental forward progress. Still don't feel super great about the "at least 1" thing and the disparate storage limits (preferred size versus break-because-too-big size), but given the varied opinions, seems like the incremental progress is probably the best path forward for now. (perfect being the enemy of good and all that)

Thanks Dave. Totally agreed that this is a mismash of compromises but that even in this form it still helps push the discussion forward towards rationalizing our vector/smallvector usage. Once we rationalize it, we will hopefully be able to circle back and put this on a more principled foundation consistent with our overarching conclusions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92522/new/

https://reviews.llvm.org/D92522



More information about the llvm-commits mailing list