[PATCH] D92074: [llvm-profdata] Emit Error when Invalid MemOpSize Section is Created by llvm-profdata

[Matthew Voss via Phabricator via llvm-commits]

ormris added a comment.

> I would rather to fix this in the memop size transformation -- to detect this in the heuristic.

I think it would be valuable to guard against this pattern within the transform, but I'm concerned that putting the error in the pass would make it harder to debug this issue. If we detect this in llvm-profdata, the user is more likely to have/provide the profraw files causing this behavior.

> Should we do something in profile runtime to prevent this.

Do you think llvm-profdata could be causing this issue? I was thinking that profdata might be merging two profiles incorrectly. Either way, having the profraw files would be valuable for debugging...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92074/new/

https://reviews.llvm.org/D92074