[PATCH] D92500: ADT: Replace guts of AlignedCharArrayUnion with std::aligned_union_t, NFC

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 15:57:58 PST 2020


dexonsmith added a comment.

In D92500#2429554 <https://reviews.llvm.org/D92500#2429554>, @rnk wrote:

> lgtm
>
> I checked MSVC 19.14, and this type works.

Thanks for doing that; pushed / committed this in 65c5c9f92ec514ae41c8ea407d1c885737d699ec <https://reviews.llvm.org/rG65c5c9f92ec514ae41c8ea407d1c885737d699ec>. I'll avoid piling anything else on top until tomorrow to give extra time for a clean revert in case there's some unexpected case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92500/new/

https://reviews.llvm.org/D92500



More information about the llvm-commits mailing list