[PATCH] D92459: [dfsan] Rename ShadowTy/ZeroShadow with prefix Primary
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 14:31:21 PST 2020
morehouse accepted this revision.
morehouse added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:357-358
Type *Int8Ptr;
- IntegerType *ShadowTy;
- PointerType *ShadowPtrTy;
+ /// The shadow type for all primitive types. Aggregate and vector types also
+ /// use this shadow type before supporting field/index-level shadow values.
+ IntegerType *PrimitiveShadowTy;
----------------
================
Comment at: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp:364
+ /// vector values also use this shadow const before supporting shadow values
+ /// at field/index-level.
+ ConstantInt *ZeroPrimitiveShadow;
----------------
I think this comment is unnecessary since the previous comment explains enough.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92459/new/
https://reviews.llvm.org/D92459
More information about the llvm-commits
mailing list