[PATCH] D92458: [dfsan] Rename CachedCombinedShadow to be CachedShadow
Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 13:40:38 PST 2020
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdad5d9588335: [dfsan] Rename CachedCombinedShadow to be CachedShadow (authored by Jianzhou Zhao <jianzhouzh at google.com>).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92458/new/
https://reviews.llvm.org/D92458
Files:
llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
Index: llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
===================================================================
--- llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
+++ llvm/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
@@ -428,12 +428,12 @@
std::vector<Value *> NonZeroChecks;
bool AvoidNewBlocks;
- struct CachedCombinedShadow {
- BasicBlock *Block;
+ struct CachedShadow {
+ BasicBlock *Block; // The block where Shadow is defined.
Value *Shadow;
};
- DenseMap<std::pair<Value *, Value *>, CachedCombinedShadow>
- CachedCombinedShadows;
+ /// Maps a value to its latest shadow value in terms of domination tree.
+ DenseMap<std::pair<Value *, Value *>, CachedShadow> CachedShadows;
DenseMap<Value *, std::set<Value *>> ShadowElements;
DFSanFunction(DataFlowSanitizer &DFS, Function *F, bool IsNativeABI)
@@ -1145,7 +1145,7 @@
auto Key = std::make_pair(V1, V2);
if (V1 > V2)
std::swap(Key.first, Key.second);
- CachedCombinedShadow &CCS = CachedCombinedShadows[Key];
+ CachedShadow &CCS = CachedShadows[Key];
if (CCS.Block && DT.dominates(CCS.Block, Pos->getParent()))
return CCS.Shadow;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92458.309046.patch
Type: text/x-patch
Size: 1189 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201202/e4dd0617/attachment.bin>
More information about the llvm-commits
mailing list