[PATCH] D92073: [CodeGen] Add text section prefix for COFF object file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 13:23:05 PST 2020


mstorsjo added inline comments.


================
Comment at: llvm/test/CodeGen/X86/text-section-prefix.ll:20
+; COFF-MSVC:  .section  .text$unlikely,"xr",one_only,foo2
+; COFF-GNU:   .section  .text$unlikely$foo2,"xr",one_only,foo2
+  ret void
----------------
rnk wrote:
> @mstorsjo This seems a bit more complicated than I originally thought it would be.
Yeah, but I guess this is what we end up with, if we append things this way. I wonder whether this works properly when interacting with GNU ld?

The patch description has very little context about the what/where/why - so this is something that ends up invoked only if building with PGO?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92073/new/

https://reviews.llvm.org/D92073



More information about the llvm-commits mailing list