[PATCH] D92056: [LoopVec] Support global addresses as argument to uniform mem ops

[Anna Thomas via Phabricator via llvm-commits]

anna added a comment.

Nice catch! LGTM from me. One comment inline. Pls see if @fhahn has any comments as well?



================
Comment at: llvm/test/Transforms/LoopVectorize/X86/cost-model-assert.ll:52
+; CHECK-NEXT:    [[TMP17:%.*]] = load i8, i8* undef, align 1, [[TBAA1]]
+; CHECK-NEXT:    [[TMP18:%.*]] = or <4 x i32> [[TMP14]], zeroinitializer
+; CHECK-NEXT:    [[TMP19:%.*]] = or <4 x i32> [[TMP15]], zeroinitializer
----------------
Any idea why these extra no-ops get added? That seems like an unfortunate side effect (especially given the algorithm works to reduce compile time). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92056/new/

https://reviews.llvm.org/D92056