[PATCH] D92505: [ms] [llvm-ml] Warn on redefinition of a command-line definition

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 13:07:48 PST 2020


epastor created this revision.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.
epastor requested review of this revision.

If a macro is defined on the command line and then overridden in the source code, this is likely to be an error in the user's build system. We should warn on this.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D92505

Files:
  llvm/lib/MC/MCParser/MasmParser.cpp
  llvm/test/tools/llvm-ml/command_line_defines.asm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D92505.309040.patch
Type: text/x-patch
Size: 3683 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201202/a827b927/attachment.bin>


More information about the llvm-commits mailing list