[PATCH] D92478: [yaml2obj/obj2yaml] - Make fields of the `Symbol` to be optional.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 12:57:08 PST 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/obj2yaml/elf2yaml.cpp:675
   S.Other = Sym->st_other;
-  S.Binding = Sym->getBinding();
+  if (Sym->getBinding() != ELF::STB_LOCAL)
+    S.Binding = Sym->getBinding();
----------------
For undefined symbols, STB_GLOBAL is the default.
For defined symbols, STB_LOCAL is the default.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92478/new/

https://reviews.llvm.org/D92478



More information about the llvm-commits mailing list