[PATCH] D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 2 11:12:52 PST 2020


Meinersbur added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282
+  InsertPointTy createStaticWorkshareLoop(const LocationDescription &Loc,
+                                          CanonicalLoopInfo *LoopInfo,
+                                          InsertPointTy AllocaIP,
----------------
kiranchandramohan wrote:
> No change required but just asking a question for my understanding,
> Can createWorkshareLoop call createCanonicalLoop internally?
In the patch I am working on, I extracted most of `createCanonicalLoop` into a private `createCanonicalLoopSkeleton` to be used by other `createXYZLoop` methods (in my case: tiling).

However, this patch modifies an existing CanonicalLoopInfo, instead of creating a new one.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92476/new/

https://reviews.llvm.org/D92476



More information about the llvm-commits mailing list