[PATCH] D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Thanks @ftynse for this patch. This is great and will speed us up by a month.



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282
+  InsertPointTy createStaticWorkshareLoop(const LocationDescription &Loc,
+                                          CanonicalLoopInfo *LoopInfo,
+                                          InsertPointTy AllocaIP,
----------------
No change required but just asking a question for my understanding,
Can createWorkshareLoop call createCanonicalLoop internally?


================
Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:1082
+  Builder.CreateCall(StaticFini, {SrcLoc, ThreadNum});
+
+  return Builder.saveIP();
----------------
A barrier insertion with a TODO to look at nowait attribute?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92476/new/

https://reviews.llvm.org/D92476