[PATCH] D92492: [flang] Fix bugs related to merging generics during USE

[Pete Steinfeld via Phabricator via llvm-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.

It would be good to also fix the lint changes that were automatically suggested.

Aside from my comments, all builds, tests, and looks good.



================
Comment at: flang/lib/Semantics/check-declarations.cpp:1903
+  } else {
+    msg = &context_.Say(*GetTopLevelUnitContaining(proc1).GetName(),
+        "USE-associated generic '%s' may not have specific procedures '%s' and"
----------------
It would be good to have a test the produces this message.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:2422
+        Say(location,
+            "Generic interface '%s' has ambiguous derived types"
+            " from modules '%s' and '%s'"_err_en_US,
----------------
I realize that his message was there before your change, but it would be good to have a test that produces it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92492/new/

https://reviews.llvm.org/D92492