[PATCH] D92491: [flang][NFC] Add GetTopLevelUnitContaining functions
Tim Keith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 2 10:28:17 PST 2020
tskeith added inline comments.
================
Comment at: flang/include/flang/Semantics/tools.h:33
+// Note: Here ProgramUnit includes internal subprograms while TopLevelUnit
+// does not. "program-unit" in the Fortran standard matches TopLevelUnit.
----------------
klausler wrote:
> "top level unit" is self-defining and I like it. Can we avoid "program unit" altogether, though? (It can't be "subprogram", either.)
Avoiding "program unit" would be good but I haven't been able to come up with a better term.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92491/new/
https://reviews.llvm.org/D92491
More information about the llvm-commits
mailing list