[PATCH] D92492: [flang] Fix bugs related to merging generics during USE

[Peter Klausler via Phabricator via llvm-commits]

klausler accepted this revision.
klausler added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Semantics/CMakeLists.txt:1
+set(CMAKE_CXX_FLAGS_RELEASE_G1_O0 "-g1 -O0")
+set(CMAKE_BUILD_TYPE RELEASE_G1_O0)
----------------
Should these remain?


================
Comment at: flang/lib/Semantics/resolve-names.cpp:2417
+  } else if (auto *genericDetails{localSymbol.detailsIf<GenericDetails>()}) {
+    if (auto *useDetails{useSymbol.detailsIf<GenericDetails>()}) {
+      AddGenericUse(*genericDetails, localName, useSymbol);
----------------
clang-tidy's suggested `const auto *` seems good to me here.


================
Comment at: flang/lib/Semantics/symbol.cpp:261
             [&](const DerivedTypeDetails &) {
-              auto *derived{this->detailsIf<DerivedTypeDetails>()};
+              auto *derived{detailsIf<DerivedTypeDetails>()};
               return derived && derived->isForwardReferenced();
----------------
`const` here too


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92492/new/

https://reviews.llvm.org/D92492